SHARE-471 Improved all-time ranking of projects #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubes
changed the title
dmetzner
reviewed
Oct 31, 2023
Comment on lines
24
to
27
| $this->addSql('ALTER TABLE studio_activity CHANGE type type ENUM(\'comment\', \'project\', \'user\')'); | ||
| $this->addSql('ALTER TABLE studio_user CHANGE role role ENUM(\'admin\', \'member\'), CHANGE status status ENUM(\'active\', \'banned\', \'pending_request\')'); | ||
| $this->addSql('ALTER TABLE user_like_similarity_relation CHANGE similarity similarity NUMERIC(4, 3) DEFAULT \'0\' NOT NULL'); | ||
| $this->addSql('ALTER TABLE user_remix_similarity_relation CHANGE similarity similarity NUMERIC(4, 3) DEFAULT \'0\' NOT NULL'); |
There was a problem hiding this comment.
Those 4 lines can be removed, they have no effect, and will be in every migration. There must be a misconfiguration in our settings. You can remove them
dmetzner
reviewed
Oct 31, 2023
| $this->entity_manager->flush(); | ||
| $output->writeln('Popularity scores have been updated'); | ||
|
|
||
| return Command::SUCCESS; |
There was a problem hiding this comment.
I think this command will run in a timeout, but we can test it out with the next deployment.
dmetzner
approved these changes
Oct 31, 2023
|
LGTM - please resolve the conflict :) |
removed unnecessary lines in migration
Codecov Report
@@ Coverage Diff @@
## develop #4448 +/- ##
=============================================
- Coverage 49.66% 49.19% -0.48%
- Complexity 5690 5707 +17
=============================================
Files 662 663 +1
Lines 20499 20597 +98
=============================================
- Hits 10181 10132 -49
- Misses 10318 10465 +147
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.
SHARE-666 The devils ticketCode Reviewsection in JiraAdditional Description
TODO: Add additional information that is not in your commit-message hereTests - additional information
TODO: add additional information about testruns here