Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-539 Improve feedback for download project button #3745

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

EifonUser
Copy link
Contributor


Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing (CI), if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer
  • Check that your pull request has been successfully deployed to https://web-test-1.catrob.at/

Additional Description

SweetAlert is commented out, because I felt like it makes the user experience worse. So it can be added if still needed.

Tests - additional information

TODO: add additional information about testruns here

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #3745 (edff54f) into develop (b7247c6) will increase coverage by 28.88%.
The diff coverage is 66.66%.

@@              Coverage Diff               @@
##             develop    #3745       +/-   ##
==============================================
+ Coverage      21.24%   50.13%   +28.88%     
- Complexity      5693     5694        +1     
==============================================
  Files            655      655               
  Lines          20369    20363        -6     
==============================================
+ Hits            4327    10208     +5881     
+ Misses         16042    10155     -5887     
Flag Coverage Δ
behat 47.95% <66.66%> (+32.21%) ⬆️
phpunit 8.76% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plication/Controller/Project/ProgramController.php 63.27% <66.66%> (+63.27%) ⬆️
src/Project/CatrobatCode/Parser/CodeStatistic.php 66.94% <0.00%> (+1.65%) ⬆️
src/Api/Services/Base/TranslatorAwareTrait.php 100.00% <0.00%> (+1.67%) ⬆️
src/Api/UserApi.php 86.07% <0.00%> (+3.79%) ⬆️
src/DB/Entity/Survey.php 4.60% <0.00%> (+4.60%) ⬆️
...roject/EventListener/ProjectPostUpdateNotifier.php 70.00% <0.00%> (+5.00%) ⬆️
src/DB/Entity/Project/Extension.php 45.45% <0.00%> (+6.06%) ⬆️
src/Api/ProjectsApi.php 94.87% <0.00%> (+8.20%) ⬆️
src/Utils/ElapsedTimeStringFormatter.php 82.60% <0.00%> (+8.69%) ⬆️
...ty/Project/Scratch/ScratchProgramRemixRelation.php 63.63% <0.00%> (+9.09%) ⬆️
... and 295 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EifonUser EifonUser marked this pull request as ready for review February 14, 2023 17:51
Copy link
Collaborator

@dmetzner dmetzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few minor inputs from my side :)

assets/js/custom/Program.js Show resolved Hide resolved
@dmetzner dmetzner merged commit 5bb5f36 into Catrobat:develop Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants