Support for list recombinations #568
Conversation
|
(note: CI shows red because of a quirk that made it attempt to publish its artifacts, but tests actually passed) |
and fix the `make` clean rule
The primary use-case for this was to be able to run computations on a list of
structures, then return an updated list with some fields in the structures
modified : that is what we need for distribution of tax amounts among household
members, for example.
This patch has a few components:
- Addition of a test as an example for tax distributions
- Added a transformation, performed during desugaring, that -- where lists are
syntactically expected, i.e. after the `among` keyword -- turns a (syntactic)
tuple of lists into a list of tuples ("zipping" the lists)
- Arg-extremum transformation was also fixed to use an intermediate list instead
of computing the predicate twice
- For convenience, allow to bind multiple variables in most* list
operations (previously only `let in` and functions allowed it)
- Fixed the printer for tuples to differentiate them from lists
*Note: tuples are not yet allowed on the left-hand side of filters and
arg-extremums for annoying syntax conflict reasons.
| m | ||
| in | ||
| zip ls | ||
| | e -> rec_helper e |
There was a problem hiding this comment.
No error message at this point ? Does this mean that the error will be raised later during typing?
There was a problem hiding this comment.
No it's the correct case for non-tuple arguments
| Var.make (String.concat "_" (List.map Mark.remove param_names)) | ||
| in | ||
| let x = Expr.evar v emark in | ||
| let tys = List.map (fun _ -> TAny, pos) param_names in |
There was a problem hiding this comment.
Is there any way to be smarter than TAny here or in the other instances of changes in this file?
There was a problem hiding this comment.
I don't think so, remember this is desugaring so there is very little type information available, except for top-level definitions. We do enforce tuples of the correct length though.
| @@ -353,6 +353,7 @@ module Oper : sig | |||
| val o_xor : bool -> bool -> bool | |||
| val o_eq : 'a -> 'a -> bool | |||
| val o_map : ('a -> 'b) -> 'a array -> 'b array | |||
| val o_map2 : ('a -> 'b -> 'c) -> 'a array -> 'b array -> 'c array | |||
There was a problem hiding this comment.
Missing comment : raises NotSameLength
| @@ -0,0 +1,65 @@ | |||
| > Using Prorata_external as Ext | |||
There was a problem hiding this comment.
Where is Prorata_external defined ? Is this really how you're supposed to use this builtin? Will it be the same for other builtins?
There was a problem hiding this comment.
It's not a built-in at the moment, it's an external defined in tests/test_modules/prorata_external.{catala_en,ml}
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
(far from perfect but there is an HOWTO about how to handle it in its current state: https://github.com/CatalaLang/catala/blob/master/doc/devel/externals.md)
The primary use-case for this was to be able to run computations on a list
of structures, then return an updated list with some fields in the
structures modified : that is what we need for distribution of tax amounts
among household members, for example.
This patch has a few components:
Addition of a test as an example for tax distributions (and tests for various
cases of the below desugaring)
Internally added a
Map2operator that is used as backend for the followingAdded a transformation, performed during desugaring, that -- where lists
are syntactically expected, i.e. after the
amongkeyword -- turns a(syntactic) tuple of lists into a list of tuples ("zipping" the lists)
Arg-extremum transformation was also fixed to use an intermediate list
instead of computing the predicate twice
For convenience, allow to bind multiple variables in most* list
operations (previously only
let inand functions allowed it)Fixed the printer for tuples to differentiate them from lists
*Note: tuples are not yet allowed on the left-hand side of filters and
arg-extremums for annoying syntax conflict reasons.