Improve missing field error message #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denismerigoux
added
✨ enhancement
AltGr
approved these changes
Jan 24, 2024
AltGr
reviewed
Jan 24, 2024
| if | ||
| StructField.Map.exists | ||
| (fun expected_f _ -> not (StructField.Map.mem expected_f s_fields)) | ||
| expected_s_fields |
There was a problem hiding this comment.
I generally find it nicer to write let missing = Map.diff expected fields in if not (Map.is_empty missing) then ..., but it's generally less efficient and well Map doesn't have a proper diff function (although you can use merge for that 🤷) so this is fine ;)
There was a problem hiding this comment.
I didn't know you coud use Map.merge to implement some sort of Map.diff. I'll remember it next time :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.