Information about variable I/O in log events #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denismerigoux
added
✨ enhancement
EmileRolley
approved these changes
May 29, 2023
There was a problem hiding this comment.
Looks good to me 👍
I was able to use the new io attribute of var_def to add more information on the log event visualizer -- see the PR.
Unfortunately, I was unable to use the packages locally with yarn link. So, I needed to publish new version :/
|
I validate the changes in the OCaml code, but the changes in |
|
Let's merge this and pray the CI on master works anyway ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces information about the I/O of variables in the log events of kind
VarDef.