Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add a ReScript runtime and a wrapper for french_law.js #464

Merged
merged 11 commits into from
May 7, 2023

Conversation

EmileRolley
Copy link
Collaborator

@EmileRolley EmileRolley commented May 5, 2023

Packages:

Related PR from the website: CatalaLang/catala-website#52

@EmileRolley EmileRolley added the 🔚 backends Backend runtime or code generation label May 5, 2023
@EmileRolley EmileRolley marked this pull request as ready for review May 5, 2023 10:02
@EmileRolley EmileRolley changed the title feat(runtimes): add rescript-catala Feat: add a ReScript runtime and a wrapper for french_law.js May 5, 2023
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this high-quality PR. Just a few nitpickings and we can merge!

french_law/js/package-lock.json Outdated Show resolved Hide resolved
french_law/js/package.json Outdated Show resolved Hide resolved
generate_website_assets.sh Outdated Show resolved Hide resolved
runtimes/rescript/README.md Show resolved Hide resolved
@EmileRolley EmileRolley merged commit 8612130 into master May 7, 2023
@EmileRolley EmileRolley deleted the feat-rescript-runtime branch May 7, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔚 backends Backend runtime or code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants