Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: improve the HTML generation with ToC and details tags #303

Merged
merged 8 commits into from
Aug 5, 2022

Conversation

EmileRolley
Copy link
Collaborator

@EmileRolley EmileRolley commented Aug 2, 2022

Related issue: CatalaLang/catala-website#33

To facilitate navigation inside generated HTML pages, this PR adds the generation of ToC and adds <details> tags around <h2> sections.

New Utils.String_common module grouping helper functions about string manipulation based on Ubase, which allows to remove : Lcalc.Backends and Lcalc.Print modules.

Demo new

deepin-screen-recorder_brave-browser_20220804191213.mp4

@EmileRolley EmileRolley added ✨ enhancement New feature or request 🔚 backends Backend runtime or code generation labels Aug 2, 2022
@EmileRolley EmileRolley changed the title feat(backends/html): add TOC and collapse <h2> sections Feat: improve the HTML generation with ToC and details tags Aug 2, 2022
@EmileRolley EmileRolley force-pushed the feat-add-details-to-html branch 2 times, most recently from a8bc372 to 2406ebe Compare August 2, 2022 13:26
@EmileRolley EmileRolley requested a review from AltGr August 2, 2022 13:29
EmileRolley added a commit to CatalaLang/catala-website that referenced this pull request Aug 2, 2022
@EmileRolley EmileRolley marked this pull request as draft August 2, 2022 13:38
@EmileRolley EmileRolley marked this pull request as ready for review August 2, 2022 14:17
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks ! When you're done with the refactoring to remove some of my old code you can merge.

compiler/literate/html.ml Outdated Show resolved Hide resolved
Copy link
Contributor

@AltGr AltGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EmileRolley added a commit to CatalaLang/catala-website that referenced this pull request Aug 4, 2022
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A brilliant PR for a brilliant ending to your internship ! As always I've left a few nitpicks but I feel we should merge this soon.

compiler/utils/string_common.ml Show resolved Hide resolved
compiler/literate/html.ml Outdated Show resolved Hide resolved
compiler/literate/html.ml Outdated Show resolved Hide resolved
@denismerigoux denismerigoux merged commit e5d6c26 into master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔚 backends Backend runtime or code generation ✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants