-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: improve the HTML generation with ToC and details tags #303
Conversation
a8bc372
to
2406ebe
Compare
+ changes introduced by the PR: CatalaLang/catala#303
2406ebe
to
ca05f66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great, thanks ! When you're done with the refactoring to remove some of my old code you can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ca05f66
to
1afd314
Compare
+ changes introduced by the PR: CatalaLang/catala#303
10e6f10
to
7023a8d
Compare
…ls.String_common module based on Ubase
7023a8d
to
5534145
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A brilliant PR for a brilliant ending to your internship ! As always I've left a few nitpicks but I feel we should merge this soon.
…lete the doc of the Utils module
6b8777d
to
f30dc37
Compare
Related issue: CatalaLang/catala-website#33
To facilitate navigation inside generated HTML pages, this PR adds the generation of ToC and adds
<details>
tags around<h2>
sections.New
Utils.String_common
module grouping helper functions about string manipulation based onUbase
, which allows to remove :Lcalc.Backends
andLcalc.Print
modules.Demo new
deepin-screen-recorder_brave-browser_20220804191213.mp4