Change syntax for set membership predicate ('in' -> 'contains') #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am surprised that only 1 test and no examples are affected by the change 🤨 |
Closed
Before: `ELEMENT in SET`; now: `SET contains ELEMENT` Using the `in` keyword was causing conflicts and blocking CatalaLang#203. Current proposal has `contient` for the French syntax, and is untranslated (`contains`) for Polish.
|
Update: replaced "comprend" by "contient" for the french version, and got a ✔️ from the legal team |
denismerigoux
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a small CLI patch