Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(runtime/api_web): parse raw log events into structured ones #280

Merged
merged 9 commits into from
Jun 20, 2022
Merged

Refactor(runtime/api_web): parse raw log events into structured ones #280

merged 9 commits into from
Jun 20, 2022

Conversation

EmileRolley
Copy link
Collaborator

@EmileRolley EmileRolley commented Jun 9, 2022 •
edited
Loading

Global refactoring of the log events by introducing structured events and a parser to build them from raw events -- previous Runtime.event type.

Changelog

  • New structured log event type:
    • The previous event type is now the raw_event.
    • New parser: val Runtime.EventParser.parse_raw_events : raw_event list -> event list.
    • New pretty printer: pp_events.
  • Refactored web API with new functions: retrieveEvents and retrieveRawEvents.
  • Input and output of function call now have types in logs (see d82ecb5)
  • Removes the -s flag from the law_source/unit_tests/tests_allocations_familiales.ml Makefile rule.

@EmileRolley EmileRolley added ✨ enhancement New feature or request 🔧 compiler Issue concerns the compiler 🔚 backends Backend runtime or code generation labels Jun 9, 2022
@EmileRolley EmileRolley force-pushed the specify-logs-struct branch 3 times, most recently from 9c3282d to 52edb61 Compare June 15, 2022 17:53
denismerigoux
denismerigoux reviewed Jun 16, 2022
View reviewed changes
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now :)

compiler/runtime.ml Outdated Show resolved Hide resolved
compiler/runtime.mli Show resolved Hide resolved
compiler/runtime.mli Show resolved Hide resolved
compiler/scopelang/scope_to_dcalc.ml Show resolved Hide resolved
@EmileRolley EmileRolley marked this pull request as ready for review June 16, 2022 15:31
denismerigoux
denismerigoux approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, thanks!

@denismerigoux denismerigoux merged commit 94cf874 into master Jun 20, 2022
@EmileRolley EmileRolley mentioned this pull request Jun 22, 2022
Open
@EmileRolley EmileRolley deleted the specify-logs-struct branch June 24, 2022 09:08
@EmileRolley EmileRolley mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denismerigoux denismerigoux denismerigoux approved these changes

Assignees
No one assigned
Labels
🔚 backends Backend runtime or code generation 🔧 compiler Issue concerns the compiler ✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmileRolley @denismerigoux