Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nix part 4 #278

Merged
merged 6 commits into from
Jun 7, 2022
Merged

Fix nix part 4 #278

merged 6 commits into from
Jun 7, 2022

Conversation

adelaett
Copy link
Collaborator

@adelaett adelaett commented Jun 6, 2022

30297b27b87ba87ed8dc9ab10787bd1876a0ce6b added dune runtests, but those are called too when building clerk or ninja-utils, making a circular dependency between ninja-utils and catala.

this pull request add (package catala) to only run the created runtest when building catala

@adelaett adelaett added the 🏗️ build system Build system or Makefile label Jun 6, 2022
@adelaett adelaett marked this pull request as draft June 7, 2022 06:14
@adelaett adelaett changed the title Change dune rule to build tests only for catala Fix nix part 4 Jun 7, 2022
@adelaett
Copy link
Collaborator Author

adelaett commented Jun 7, 2022

@adelaett adelaett marked this pull request as ready for review June 7, 2022 07:03
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@denismerigoux denismerigoux merged commit 1f4e869 into master Jun 7, 2022
@denismerigoux denismerigoux deleted the dune-test-fixup branch September 6, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ build system Build system or Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants