Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nix expressions and convert them to flakes (Continuation) #271

Merged
merged 5 commits into from
May 31, 2022
Merged

Fix Nix expressions and convert them to flakes (Continuation) #271

merged 5 commits into from
May 31, 2022

Conversation

adelaett
Copy link
Collaborator

@adelaett adelaett commented May 30, 2022 •
edited
Loading

WIP

Continuation of #270. Todo:

  • adjust github action
  • add an action to update flakes every week (in .github/workflow/update-flake-lock.yml)
  • modify the documentation
  • (optional) add documentation on how to add new packages in the nix part of the system

@adelaett
Copy link
Collaborator Author

see https://github.com/CatalaLang/catala/runs/6656096447 for a validation run

@adelaett
Copy link
Collaborator Author

https://github.com/CatalaLang/catala/runs/6670244139 for a working run

@adelaett
Copy link
Collaborator Author

adelaett commented May 31, 2022 •
edited
Loading

I'm unsure on how i should test the other workflow (that update the flake lock). Maybe we can push it to master and then launch it inside the https://github.com/CatalaLang/catala/actions tab ? @denismerigoux

@adelaett adelaett marked this pull request as ready for review May 31, 2022 12:16
@denismerigoux
Copy link
Contributor

Maybe we can push it to master and then launch it inside the https://github.com/CatalaLang/catala/actions tab ?

Sounds good

@denismerigoux denismerigoux merged commit c9f5555 into master May 31, 2022
@denismerigoux
Copy link
Contributor

It still doesn't work? https://github.com/CatalaLang/catala/runs/6670856487?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denismerigoux denismerigoux denismerigoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adelaett @denismerigoux