Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the web API by serializing runtime values #267

Merged
merged 1 commit into from
May 25, 2022
Merged

Refactor the web API by serializing runtime values #267

merged 1 commit into from
May 25, 2022

Conversation

EmileRolley
Copy link
Collaborator

Runtime.runtime_value are now serialized with yojson.

Changelog

  • Instruments the Runtime module with ppx_yojson_conv.
  • Refactors the web_api.ml to return the string representation of the serialized runtime_value inside the log_event record.
  • Adds minimal documentation about the API in ./french_law/js/README.md.

@EmileRolley EmileRolley added 🔧 compiler Issue concerns the compiler 🔚 backends Backend runtime or code generation labels May 25, 2022
denismerigoux
denismerigoux approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@denismerigoux denismerigoux merged commit 5b4ab6d into master May 25, 2022
@EmileRolley EmileRolley deleted the refactor-web-api branch June 9, 2022 07:41
@EmileRolley EmileRolley mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denismerigoux denismerigoux denismerigoux approved these changes

Assignees
No one assigned
Labels
🔚 backends Backend runtime or code generation 🔧 compiler Issue concerns the compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmileRolley @denismerigoux