Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of French housing benefits : 2/N #266

Merged
merged 51 commits into from
Jul 6, 2022
Merged

Implementation of French housing benefits : 2/N #266

merged 51 commits into from
Jul 6, 2022

Conversation

denismerigoux
Copy link
Contributor

@denismerigoux denismerigoux commented May 19, 2022 •
edited
Loading

Follow up of #165.

Pair programming sessions

  • 2021-11-26: 1 h 30 with Denis, Alain and Lilya
  • 2021-12-08: 1 h 30 with Alain, Lilya and Denis
  • 2022-02-10: 1 h 30 with Lilya and Denis
  • 2022-02-15: 2 h with Lilya and Denis
  • 2022-02-22: 1 h 30 with Lilya and Denis
  • 2022-03-09: 1 h with Lilya and Denis
  • 2022-03-14 : 1 h 30 with Lilya et Denis
  • 2022-03-16: 2 h with Lilya, Alain and Denis
  • 2022-03-18: 1 h 30 with Lilya, Alain and Denis
  • 2022-03-22: 1 h 30 with Lilya and Denis
  • 2022-03-29: 1 h 30 with Lilya and Denis
  • 2022-04-08: 2 h with Lilya and Denis
  • 2022-04-13: 3 h with Lilya and Denis
  • 2022-04-15: 3 h with Lilya and Denis
  • 2022-04-21 : 2 h with Lilya and Denis
  • 2022-05-04: 1h30 with Lilya and Denis
  • 2022-05-06 : 2 h with Lilya and Denis
  • 2022-05-19: 2 h with Lilya and Denis
  • 2022-05-20: 2 h with Lilya and Denis
  • 2022-05-24: 1 h with Lilya and Denis
  • 2022-06-01 : 2 h with Lilya and Denis
  • 2022-06-03: 2 h 30 with Lilya and Denis

Refactoring sessions

  • 2022-02-18: 1 h with Denis
  • 2022-02-25: 0,5 h with Denis
  • 2022-03-15: 1 h with Denis
  • 2022-03-21: 1 h with Denis
  • 2022-03-30: 0,5 h with Denis
  • 2022-03-14 : 3h with Lilya
  • 2022-04-28: 1 h with Denis
  • 2022-04-29: 6 h with Denis
  • 2022-05-04: 3 h with Denis
  • 2022-05-04: 1 h with Denis
  • 2022-06-06: 3 h with Denis
  • 2022-07-06: 3 h with Denis

Legal research sessions

  • 2022-03-04 : 2 h with Lilya
  • 2022-03-09 : 1 h with Lilya
  • Various sessions of copy-pasting from LegiFrance : 10 h
  • 2022-04-06: 2 h
  • 2022-04-07: 5 h
  • 2022-04-08: 1 h 30

Testing

  • 2022-05-02 : 3,5 h with Lilya
  • 2022-05-03 : 4 h with Lilya
  • 2022-05-05 : 2 h with Lilya and Denis
  • 2022-05-06: 1 h with Lilya
  • 2022-05-09: 2 h with Lilya
  • 2022-06-01 : 1 h with Lilya

@denismerigoux denismerigoux added the ⚖️ program This issue concerns some Catala program label May 19, 2022
denismerigoux and others added 28 commits May 20, 2022 16:37
@denismerigoux
End of accession-propriété for AL with @Lilyaslm
6638913
@denismerigoux
New questions by @Lilyaslm
883375d
@Lilyaslm
Mise à jour des tests
6f5d924
@Lilyaslm
Merge branch 'allocations_logement' of https://github.com/CatalaLang/…
63b05e3 
…catala into allocations_logement
@denismerigoux
Finished logement foyer réglementaires (minus TODOs) with @Lilyaslm
54a08d4
@denismerigoux
Put @Lilyaslm's tests under CI
e207fac
@denismerigoux
New questions
2a8e7f5
@Lilyaslm
Suite de l'arrêté du 27 / 09 / 2019
65ba54b
@Lilyaslm
Merge branch 'allocations_logement' of https://github.com/CatalaLang/…
78e215e 
…catala into allocations_logement
@denismerigoux
Fix missing parenthesis
225bd4a
@denismerigoux
Merge branch 'master' into allocations_logement
7abaf82
@denismerigoux
Add "print_only_law" option
ec22599
@denismerigoux
Add missing options
fd7d9a6
@denismerigoux
Merge branch 'allocations_logement' of github.com:CatalaLang/catala i…
ff1b4eb 
…nto allocations_logement
@denismerigoux
More SMIC Data + table formatting
7c779a0
@denismerigoux
Better error message
878de02
@denismerigoux
Added missing rent values for foyer housing
ff24f7d
@denismerigoux
Intégration réponses DGLAN/DHUP/FE4 du 25/05/2022
ae8d59d
@denismerigoux
Added exceptional values not found in law but confirmed by administra…
c93cb10 
…tion
@denismerigoux
DGALN not DGLAN
77baeb7
@denismerigoux
Another precision
05a1405
@denismerigoux
Merge branch 'master' into allocations_logement
ab0f4eb
@denismerigoux
Add TODOs
c967161
@denismerigoux
Implemented horrible horrible article 33 with @Lilyslm
86bdd7d
@Lilyaslm
Test Logement Foyer
8ceb6f0
@Lilyaslm
Merge branch 'allocations_logement' of https://github.com/CatalaLang/…
b4626b8 
…catala into allocations_logement
@denismerigoux
Finished last arrêtés with @Lilyaslm!
a29a8d5
@Lilyaslm
Merge branch 'allocations_logement' of https://github.com/CatalaLang/…
158feef 
…catala into allocations_logement
@denismerigoux
A few tests for logement foyer
7b72a4c
@denismerigoux
Fix and tests
d058936
@denismerigoux
Rename ParentÀCharge -> AutrePersonneÀCharge
4ba73a8
@denismerigoux
Distinguo entre aides personnelle et aide personnalisée
8ddb157
@denismerigoux
Remove part of law not necessary for computation
098621a
@denismerigoux
Removed part of too long name
d80d4bc
@denismerigoux
Added justification for CRDS
fba22ab
@denismerigoux
Nitpicks
ff7e94d
@denismerigoux
Added big allocations logement branching calculator that distributes …
60089bb 
…by sector like the APL one
@denismerigoux
Restore test
f2b3cdc
@denismerigoux
Restore test
316f238
@denismerigoux
Better translation of D823-20
b77dc8c
@denismerigoux
Better translation of D823-20
eef14fe
@denismerigoux
Merge branch 'allocations_logement' of github.com:CatalaLang/catala i…
29b736e 
…nto allocations_logement
@denismerigoux
Fix sign bugs
0ab22df
@denismerigoux
Added a global "calculette" tested with a dummy example
cfe9f0c
@denismerigoux
Prepping for split custody
cd6840f
@denismerigoux
Restore test
443a4bb
@denismerigoux
We now compute the split custody!
b1dd3a8
@denismerigoux
Fix missing age of L841-1
9cdeb90
@denismerigoux denismerigoux marked this pull request as ready for review July 6, 2022 13:43
@denismerigoux denismerigoux merged commit fdf9d49 into master Jul 6, 2022
@denismerigoux denismerigoux mentioned this pull request Jul 11, 2022
Merged
9 tasks
@denismerigoux denismerigoux mentioned this pull request Aug 11, 2022
Merged
denismerigoux added a commit that referenced this pull request Aug 19, 2022
@denismerigoux
Improving French housing benefits (#314)
9008a7f 
Follow-up of #287, #266 and #165.
Time spent
Pair programming sessions

Before 2022-07-11: 50h (50 h for each person of the pair programming duo)

Refactoring sessions

Before 2022-07-11: 24 h
2022-07-14: 3 h

Legal research sessions

Before 2022-07-11: 21,5 h

Testing and debugging

Before 2022-07-11: 13,5 h
2022-07-11: 3 h with Denis
2022-07-13: 2 h with Denis
2022-07-14: 1 h with Denis
2022-07-16: 2 h with Denis
2022-07-19: 2 h with Denis
2022-07-21: 2 h with Denis
2022-08-11: 6 h with Denis
2022-08-15: 4 h with Denis
2022-08-16: 2 h with Denis

UI and form

2022-08-09: 8 h with Denis
2022-08-10: 8 h with Denis
2022-08-15: 2 h with Denis
2022-08-16: 2 h with Denis
2022-08-17: 6 h with Denis
2022-08-18: 4 h with Denis
@denismerigoux denismerigoux deleted the allocations_logement branch September 6, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⚖️ program This issue concerns some Catala program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denismerigoux @Lilyaslm