Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: group common functions related to backend_option in the Cli module #222

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Refactor: group common functions related to backend_option in the Cli module #222

merged 2 commits into from
Mar 9, 2022

Conversation

EmileRolley
Copy link
Collaborator

Simply group catala_backend_option_to_string and catala_backend_option_of_string functions in utils/cli.ml.

@EmileRolley EmileRolley added 🔧 compiler Issue concerns the compiler 🏗️ build system Build system or Makefile labels Mar 8, 2022
@AltGr
Copy link
Contributor

AltGr commented Mar 8, 2022

This will conflict with #221 (there is some overlap between what they do!), if it's ok I think #221 can go first, then I can take care of rebasing the remaining improvements from this one.

@EmileRolley
Copy link
Collaborator Author

Of course!

denismerigoux
denismerigoux approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emile!! Once it's rebased/merged on top of master, let's go :)

@AltGr
Copy link
Contributor

AltGr commented Mar 9, 2022

Ah actually it does't conflict! I had in mind another local patch that I didn't put #221 yet. So feel free to merge and I'll handle the rebase of my second part of the patch :)

@denismerigoux denismerigoux merged commit 41cf1ec into master Mar 9, 2022
@denismerigoux denismerigoux deleted the refactor-catala_backend_option-functions branch March 21, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denismerigoux denismerigoux denismerigoux approved these changes

Assignees
No one assigned
Labels
🏗️ build system Build system or Makefile 🔧 compiler Issue concerns the compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmileRolley @AltGr @denismerigoux