Use format strings directly in debug/error/log functions #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids many intermediate calls to e.g. `Format.asprintf`; should result in some cases in "more correct" use of `Format`¹, avoid the computation of unused debug strings, and make the code more readable. ¹ for `Format` to work as expected, all intermediate calls need to go through it. Some cases of formatting to an intermediate string then printing through Format again are still present, but this makes the situation better.
|
(note: this should be reviewed and merged if fit with high priority due to the high potential for merge conflicts :) ) |
EmileRolley
added
✨ enhancement
denismerigoux
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids many intermediate calls to e.g.
Format.asprintf; should resultin some cases in "more correct" use of
Format¹, avoid the computation ofunused debug strings, and make the code more readable.
¹ for
Formatto work as expected, all intermediate calls need to go throughit. Some cases of formatting to an intermediate string then printing through
Format again are still present, but this makes the situation better.