Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(clerk): sort subdirectory names #215

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix(clerk): sort subdirectory names #215

merged 1 commit into from
Mar 7, 2022

Conversation

EmileRolley
Copy link
Collaborator

Fix the issue encountered by @denismerigoux in #186 (review), by sorting directory names after a Sys.readdir call to have determined results from Ninja_utils.format.

Changelog

  • Add a new function readdir_sort.
  • Modify the failing test.

@EmileRolley EmileRolley added ❌ bug Something isn't working 🏗️ build system Build system or Makefile labels Mar 7, 2022
denismerigoux
denismerigoux approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@denismerigoux denismerigoux merged commit 2e5f870 into master Mar 7, 2022
@EmileRolley EmileRolley deleted the fix-clerk-sort-dirs branch March 7, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denismerigoux denismerigoux denismerigoux approved these changes

Assignees
No one assigned
Labels
❌ bug Something isn't working 🏗️ build system Build system or Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmileRolley @denismerigoux