-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend plugin support #213
Conversation
What should I do with this ? I propose the following:
|
Rebased ; the first patch should be fine, the second adding the demo plugins needs some cleanup (removing the dummy python plugin, decide where/how we put the jsoo one, add it to the normal build path…) |
8ab6b8f
to
f75ae06
Compare
- one that is just the same as the python backend - one that is a quick'n'dirty call to js_of_ocaml on top of the ocaml backend to generate js files Use `make plugins` to test them. They are only expected to be useful as demonstrations of how to write plugins.
Makefiles shouldn't sudo
Rebased, I think it should be OK now, and the two plugins are properly advertised as examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me code-wise but I think this plugin system is lacking some high-level documentation.
- Can you define a
plugin.mld
file incompiler/plugins
? Would this file be showed in the odoc output ? - Can you write in
CONTRIBUTING.md
a guide on how to define a new backend plugin and make it work ?
I'll do that, thanks! |
Implements #209.