-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix console formatting with colors #176
Conversation
This should do it, at least for the main printers. A few remarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, it's so satisfying! Plus the fix was relatively minor, congrats @AltGr!
@@ -131,6 +131,11 @@ let time : float ref = ref (Unix.gettimeofday ()) | |||
let print_with_style (styles : ANSITerminal.style list) (str : ('a, unit, string) format) = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you deprecate and remove this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it's still used in many places where printing doesn't go through Format, I think it can stay
I'm afraid that a lot of these paths that use a string before printing are because of me unable to use |
Well |
closes #174