add menhirLib to Nix dependencies #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeisnt
force-pushed
the
add-menhirLib-dep
branch
from
0bac374
to
d65bf98
Compare
|
@lIlIlIlIIIIlIIIllIIlIllIIllIII could you review this PR ? |
denismerigoux
added
❌ bug
If it does, it add menhirLib as a dependency. Else, ignore it.
|
Thanks for your PR. I think the issue is due to menhir split into 3 packages last year. The current version in the 21.05 channel is 20190626 (pre-split), whereas the current version on the unstable channel is 20211012 (post-split). I've added a fix compatible with both the 21.05 and the unstable channel. I've added an CI check to ensure Catala compiles against both channels. |
rename check build-nix to build-nix-21.05
adelaett
force-pushed
the
add-menhirLib-dep
branch
from
f072755
to
2fb80a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some trouble building Catala with Nix - it was missing the dependency
menhirLib- somenhirLibhas been added to thedefault.nixfile here as a dependency of catala. The nix build should be fixed.