Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to fix sdist release problem #35

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Trying to fix sdist release problem #35

merged 2 commits into from
Apr 12, 2021

Conversation

Alexander-Belyi
Copy link
Collaborator

@Alexander-Belyi Alexander-Belyi commented Apr 12, 2021 •
edited by Casyfill
Loading

setting CI/CD to pull submodules recursively

@Alexander-Belyi
Copy link
Collaborator Author

I think that should fix the problem, but not sure how to test it.

And it would still be nice to have the old version marked as failed. But I have no idea how to do it.

Casyfill
Casyfill approved these changes Apr 12, 2021
View reviewed changes
Copy link
Owner

@Casyfill Casyfill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Thanks for helping with that one!

@Casyfill Casyfill merged commit d58ea5b into master Apr 12, 2021
@Casyfill Casyfill deleted the sdist-fix branch April 12, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Casyfill Casyfill Casyfill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexander-Belyi @Casyfill