Add types for config, printer and reactor #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we merge this before or after the current code removal is done? @Jomik |
After, as you can see, it hasn't been tested 😊 |
Jomik
force-pushed
the
feat/typed-config-printer
branch
2 times, most recently
from
b3c4033 to
db24a0b
Compare
krautech
force-pushed
the
feat/typed-config-printer
branch
from
db24a0b to
5282a78
Compare
Jomik
force-pushed
the
feat/typed-config-printer
branch
3 times, most recently
from
31c303c to
e4509d8
Compare
krautech
previously approved these changes
Nov 23, 2024
Jomik
force-pushed
the
feat/typed-config-printer
branch
from
e4509d8 to
490bd16
Compare
krautech
approved these changes
Nov 23, 2024
Jomik
added a commit
that referenced
this pull request
Nov 28, 2024
* flashing via usb fixed to not say CAN Flash Success (#90) flashing via usb fixed to not say CAN Flash Success * chore: rewrote lambda as def (#83) * Chore: removed random useless code (#80) * Make MOVE argument configurable (#92) * feat: make the MOVE argument configurable Fixes #89 * feat: renamed MOVE to FUZZY_TOUCH and renamed scanner_touch_move to scanner_touch_fuzzy_move * fix: set a maxval on fuzzy_touch config --------- Co-authored-by: Chris Krause <[email protected]> * chore: create macro to help us test (#97) * feat: add 5.1.0 firmware (k1 missing) (#91) * feat: add k1 USB 5.1.0 firmware (#100) * fix: z offset bug (#102) * Removed CARTOGRAPHER_THRESHOLD_TEST (#82) * Remove PROBE_CALIBRATE and associated helper function (#81) * removed PROBE_CALIBRATE and associated helper function --------- Co-authored-by: Jonas Damtoft <[email protected]> * Added error message when error during calibration (#84) * Add types for config, printer and reactor (#94) * Add 5.1.0 HT firmware (#107) * feat: add HT firmware and -h flag to firmware.sh * fix: HT folder name + script version * fix/change max_retries float to int (#108) * feat: add types for gcode and gcode command (#106) * fix: fixes 5.1.0 HT firmware (#111) * remove duplicate line (#116) * fix: pin python version to 3.9 (#118) * removes graph generation and imports (#124) * fix: tolerance is not a tuple (#125) * change max_temp to wait_temp (#117) * Chore: Removed unused ADXL functions and variables (#114) * chore: remove adxl probing remains * removed more adxl stuff * Check firmware version before homing (#112) * feat(model): save firmware version used for calibration on model * feat(model): validate against current firmware version * fix: move mcu get_status to identify handler * fixup! feat(model): validate against current firmware version * fix: remove leftover adxl stuff This became visible after adding the type to scanner * chore: add recalibration docs url * Feature: pass params from calibrate to touch (#120) * pass params from calibrate to touch * fix: types for GCodeCommand.get_command_parameters --------- Co-authored-by: Jonas Damtoft <[email protected]> * feat: setup ci to check k1 environment (#123) * feat: setup ci to check k1 environment fix: add build tools fix: add setuptools to k1 fix: remove explicit build tools from actions fix: add setuptools for standard env add full pip3 freeze output from standard env fix: full standard env slim down standard env fix: k1 builds pycurl is not happy in gh fix: align standard env fix: update requirements to avoid breaking changes fix(k1): disable rule for K1 * fix: use numpy-stubs instead --------- Co-authored-by: KrauTech <[email protected]> Co-authored-by: Chris Krause <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a few type stubs for
ConfigWrapper,PrinterandReactor.This helps us infer proper types and catches some mistakes.
This will get rid of quite a few warnings, as well as ensure our integration is more stable in the future.
Checklist
The following relevant macros have been tested:
CARTOGRAPHER_CALIBRATEPROBEPROBE_ACCURACYCARTOGRAPHER_THRESHOLD_SCANCARTOGRAPHER_TOUCH CALIBRATE=1CARTOGRAPHER_TOUCHCARTOGRAPHER_TOUCH METHOD=manualBED_MESH_CALIBRATE