-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Threshold Scan, Touch and other small fixes #63
Conversation
Tested |
I'm not happy enough with this yet. It clearly has issues. Either 1. Its not outputting text about the other Qualify attempts or 2. Its moving onto the next threshold instead of doing all 5 qualify attempts and checking the results. cartographer-klipper/scanner.py Lines 792 to 808 in 2dfe5f0
Potentially in here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Just had that one comment I would think about :)
Looks good to me |
* feature: initial commit improved threshold scan and touch * fix: line indent * fix: removed upper limit on MAX * fix: changed text output * fix: removed double completion text * fix: changed mean to median * chore: removed more output text * fix: dont increase max if MAX is set by user * fix: change magic constants to constant variables * fix: max was still adjusting * feat: scale acceptable retries off qualification samples * fix: RETRIES is an int --------- Co-authored-by: Jonas Damtoft <[email protected]>
* feature: initial commit improved threshold scan and touch * fix: line indent * fix: removed upper limit on MAX * fix: changed text output * fix: removed double completion text * fix: changed mean to median * chore: removed more output text * fix: dont increase max if MAX is set by user * fix: change magic constants to constant variables * fix: max was still adjusting * feat: scale acceptable retries off qualification samples * fix: RETRIES is an int --------- Co-authored-by: Jonas Damtoft <[email protected]>
* feature: initial commit improved threshold scan and touch * fix: line indent * fix: removed upper limit on MAX * fix: changed text output * fix: removed double completion text * fix: changed mean to median * chore: removed more output text * fix: dont increase max if MAX is set by user * fix: change magic constants to constant variables * fix: max was still adjusting * feat: scale acceptable retries off qualification samples * fix: RETRIES is an int --------- Co-authored-by: Jonas Damtoft <[email protected]>
* feature: initial commit improved threshold scan and touch * fix: line indent * fix: removed upper limit on MAX * fix: changed text output * fix: removed double completion text * fix: changed mean to median * chore: removed more output text * fix: dont increase max if MAX is set by user * fix: change magic constants to constant variables * fix: max was still adjusting * feat: scale acceptable retries off qualification samples * fix: RETRIES is an int --------- Co-authored-by: Jonas Damtoft <[email protected]>
* feature: initial commit improved threshold scan and touch * fix: line indent * fix: removed upper limit on MAX * fix: changed text output * fix: removed double completion text * fix: changed mean to median * chore: removed more output text * fix: dont increase max if MAX is set by user * fix: change magic constants to constant variables * fix: max was still adjusting * feat: scale acceptable retries off qualification samples * fix: RETRIES is an int --------- Co-authored-by: Jonas Damtoft <[email protected]>
Description
Brings
CARTOGRAPHER_THRESHOLD_SCAN
into line withCARTOGRAPHER_TOUCH
Based on KrauTech-Nightly with improvements.
Maintains same command params from previous iteration for backwards compatibility.
Checklist
The following relevant macros have been tested:
CARTOGRAPHER_CALIBRATE
PROBE
PROBE_ACCURACY
CARTOGRAPHER_THRESHOLD_SCAN
CARTOGRAPHER_TOUCH CALIBRATE=1
CARTOGRAPHER_TOUCH
CARTOGRAPHER_TOUCH METHOD=manual
BED_MESH_CALIBRATE