Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated cartographer.py and scanner.py to update current model #52

Conversation

krautech
Copy link
Collaborator

@krautech krautech commented Nov 16, 2024

Description

Cartographer.py [cartographer] and Scanner.py [scanner] fixed models being saved to default when calling CARTOGRAPHER_CALIBRATE or CARTOGRAPHER_TOUCH and will now update based on currently loaded model, defaulting to default if no alternate model is in use.

Fixes Issue #13

Signed-off-by: Chris Krause [email protected]

@krautech krautech added the fix a bug fix label Nov 16, 2024
@krautech krautech self-assigned this Nov 16, 2024
@krautech krautech linked an issue Nov 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Nov 16, 2024
@krautech krautech added this to the v1.1 milestone Nov 16, 2024
Copy link
Collaborator

@Jomik Jomik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krautech krautech merged commit dd89705 into master Nov 16, 2024
1 check passed
@krautech krautech deleted the 13-cartographer_calibrate-applying-calibration-to-default-model branch November 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CARTOGRAPHER_CALIBRATE applying calibration to default model
2 participants