Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement strictly typed settings #142

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: implement strictly typed settings #142

wants to merge 4 commits into from

Conversation

Jomik
Copy link
Collaborator

@Jomik Jomik commented Dec 4, 2024 •
edited
Loading

Description

Checklist

The following relevant macros have been tested:

  • CARTOGRAPHER_CALIBRATE
  • PROBE
  • PROBE_ACCURACY
  • CARTOGRAPHER_THRESHOLD_SCAN
  • CARTOGRAPHER_TOUCH CALIBRATE=1
  • CARTOGRAPHER_TOUCH
  • CARTOGRAPHER_TOUCH METHOD=manual
  • BED_MESH_CALIBRATE

@Jomik Jomik self-assigned this Dec 4, 2024
@github-actions github-actions bot added the feature New feature or request label Dec 4, 2024
@Jomik Jomik force-pushed the feat/typed-settings branch 3 times, most recently from 7e8801e to cff8478 Compare December 5, 2024 13:06
@Jomik Jomik changed the title feat: ScannerSettings class feat: implement ScannerTouchSettings Dec 5, 2024
@krautech
Copy link
Collaborator

krautech commented Dec 5, 2024

Looking much cleaner

@Jomik Jomik force-pushed the feat/typed-settings branch 4 times, most recently from 58aabdb to 6a522bf Compare December 6, 2024 16:43
@Jomik Jomik marked this pull request as ready for review December 6, 2024 16:44
@Jomik Jomik force-pushed the feat/typed-settings branch from 6a522bf to a68dd86 Compare December 6, 2024 17:08
@Jomik Jomik changed the title feat: implement ScannerTouchSettings feat: implement strictly typed settings Dec 6, 2024
@Jomik Jomik force-pushed the feat/typed-settings branch 2 times, most recently from a40b7db to 32cb712 Compare December 6, 2024 19:59
@krautech krautech self-requested a review December 6, 2024 20:06
krautech
krautech previously approved these changes Dec 6, 2024
View reviewed changes
@Jomik Jomik force-pushed the feat/typed-settings branch from 32cb712 to 7b6a534 Compare December 7, 2024 15:13
@Jomik Jomik force-pushed the feat/typed-settings branch 6 times, most recently from 23ac098 to 18f711a Compare December 8, 2024 14:18
@Jomik Jomik force-pushed the feat/typed-settings branch from 18f711a to fddfd0c Compare December 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krautech krautech krautech left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Jomik Jomik

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jomik @krautech