Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model data added #109

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Add model data added #109

wants to merge 5 commits into from

Conversation

krautech
Copy link
Collaborator

Description

Adds model_created_on, model_mcu_fw and model_scanner_version to model information for help debugging

@krautech krautech added this to the v1.1.0 milestone Nov 24, 2024
@krautech krautech requested review from Jomik and RichardTHF November 24, 2024 12:40
@krautech krautech self-assigned this Nov 24, 2024
Copy link
Collaborator

@Jomik Jomik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names seem clearer to me?

scanner.py Outdated Show resolved Hide resolved
scanner.py Outdated Show resolved Hide resolved
@krautech krautech requested a review from Jomik November 24, 2024 14:11
@krautech krautech force-pushed the feat/model-data-added branch from a8287e9 to 3ab8298 Compare November 26, 2024 11:37
@Jomik
Copy link
Collaborator

Jomik commented Nov 26, 2024

Bit unsure how to handle scanner software version. Waiting for @RichardTHF to chime in.
We have discussed a bit in Discord as well.
Will just convert this to draft for now.
#112 will check the firmware version for us.

@Jomik Jomik marked this pull request as draft November 26, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants