Permalink fixes #38
Permalink fixes #38
Conversation
| filename: file.name, | ||
| status: 'uploading', | ||
| metadata: null, | ||
| provider: cloudProvider.name |
There was a problem hiding this comment.
👍 it looks like a nice approach, passing around the provider
| @@ -380,12 +385,25 @@ export function exportFileToCloud(providerName) { | |||
| .then( | |||
| response => { | |||
| if (cloudProvider.shareFile) { | |||
| dispatch(push(`/${response.url}`)); | |||
| const responseUrl = (cloudProvider.getMapPermalink) | |||
| ? cloudProvider.getMapPermalink(response.url, false) | |||
There was a problem hiding this comment.
If we're gonna start sharing / overriding behavior, maybe we should think about a base 'provider abstract class' + inheritance, so externally this would be just cloudProvider.getMapPermalink.
That would be also a way to officially declare a common provider interface.
But let's wait a bit for that...
| </div> | ||
| )} | ||
| {metaUrl && [ | ||
| (<SharingUrl key={0} url={sharingLink} message={'Share your map with other users'}/>), | ||
| (<a href={folderLink} target="_blank" rel="noopener noreferrer" style={{textDecoration: 'underline'}}>Go to your Kepler.gl Dropbox folder</a>) | ||
| (folderLink && <a href={folderLink} target="_blank" rel="noopener noreferrer" style={{textDecoration: 'underline'}}>Go to your Kepler.gl {providerName} page</a>) |
There was a problem hiding this comment.
Nice, providerName fits well here!
There was a problem hiding this comment.
With this 'old approach' (not our first one), the renderMeta method in carto-provider won't be used (delete or at least comment it out). But we might want to discuss about that in the future, as I think it is bit cleaner than this current approach.
No description provided.