Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc230232] Avoid deleting a user if it has shared entities #16424

Merged

Conversation

Shylpx
Copy link
Collaborator

@Shylpx Shylpx commented Jul 4, 2022

Resources

Context

  • In general, we don't allow deleting users with shared_entities, but there is one missing endpoint not considering this condition. So the result is that the user is deleted in Central, but the real deletion fails because it has shared entities.

Changes

  • Avoid deleting the user if it has shared_entities.

@Shylpx Shylpx requested a review from moicalcob July 4, 2022 09:51
@Shylpx Shylpx self-assigned this Jul 4, 2022
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #232062: Check shared entities when users delete themselves.

@Shylpx Shylpx changed the title Avoid deleting a user if it has shared entities [sc230232] Avoid deleting a user if it has shared entities Jul 4, 2022
Copy link
Collaborator

@moicalcob moicalcob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 🚀

@Shylpx Shylpx merged commit 1f25b5f into master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants