Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how to handle env vars on examples #70

Merged
merged 6 commits into from
Dec 27, 2017
Merged

Conversation

jsanz
Copy link
Contributor

@jsanz jsanz commented Dec 26, 2017

When running examples you are forced to set up environment variables so the arguments parsing is not meaningful. Review the way I'm proposing to handle this (there are other ways) and if you agree, please apply the same workflow to the rest of the examples so they can be run passing the credentials as parameters.

@jsanz jsanz requested a review from oriolbx December 26, 2017 16:17
@oriolbx
Copy link
Contributor

oriolbx commented Dec 27, 2017

Going to apply the same workflow to the rest of examples

@jsanz
Copy link
Contributor Author

jsanz commented Dec 27, 2017

@alrocar, before merging this fix to the examples... do you think there's anything we need to do? like tagging or deploying this to pip later, etc

@alrocar
Copy link
Contributor

alrocar commented Dec 27, 2017

Merge and I'll take care. Next time I'll write a document with the steps for publishing a new version:

  • Update NEWS file with the changes
  • Update version 1.1.1 to 1.1.2 everywhere (specially in setup.py and the doc folder)
  • Merge/tag/publish to pip

Thanks!

@jsanz jsanz requested a review from alrocar December 27, 2017 14:57
@jsanz
Copy link
Contributor Author

jsanz commented Dec 27, 2017

@alrocar added those changes, please review 😄

@alrocar
Copy link
Contributor

alrocar commented Dec 27, 2017

🇪🇸

@jsanz jsanz merged commit 85093cf into master Dec 27, 2017
@jsanz jsanz deleted the fix-env-vars-in-examples branch December 27, 2017 15:31
@jsanz
Copy link
Contributor Author

jsanz commented Dec 27, 2017

added a line to the NEWS and merged, all yours @alrocar for update on pip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants