CI test template #12
CI test template #12
Conversation
|
This pull request has been linked to Shortcut Story #428665: [App templates] Set up continuous integration (CI). |
.github/workflows/template-ci.yml
Outdated
| matrix: | ||
| # If you want to exec in all node versions, uncomment the next line | ||
| #node-version: [18.x, 20.x, 22.x] | ||
| # If you want to exec in a specific framework, uncomment the next line | ||
| #framework: [react, vue, angular] | ||
|
|
||
| # Execution | ||
| node-version: [20.x] | ||
| framework: [react] |
There was a problem hiding this comment.
Could we execute the tests in all frameworks by default? They are distinct codebases, so a regression could happen to any one of them independently. No need for other Node.js versions, to simplify.
|
|
||
| - name: Start project | ||
| env: | ||
| YARN_ENABLE_IMMUTABLE_INSTALLS: false |
There was a problem hiding this comment.
Just curious, was YARN_ENABLE_IMMUTABLE_INSTALLS required because of errors, or is it something you prefer for other reasons? If it's errors let's just leave a TODO, I can take a look at that later.
There was a problem hiding this comment.
I had to configure it because of problems with yarn.lock
.github/workflows/template-ci.yml
Outdated
| set -x | ||
| cd ${PROJECT_PATH} | ||
| yarn | ||
| yarn dev & |
There was a problem hiding this comment.
Note that each framework will open on a different port number by default, to allow opening them all at once. To override that you can run yarn dev --port 4000 instead.
Ticket: https://app.shortcut.com/cartoteam/story/428665/app-templates-set-up-continuous-integration-ci
Autolink: [sc-428665]