Feature: Experiment Archive State

[ppratikcr7]

This PR contains Archived status feature.

[danoswaltCL]

This PR contains Archived status feature.

Can we get some more technical overview of the changes that were made to aid review and know how to test? If there is any finalized document that goes over the actual requirements that were decided on after all the years of discussion, can someone point to it?

[ppratikcr7]

This PR contains Archived status feature.

Can we get some more technical overview of the changes that were made to aid review and know how to test? If there is any finalized document that goes over the actual requirements that were decided on after all the years of discussion, can someone point to it?

Sure. So we do have a document.

Requirements:

1. The archived experiments can't be unarchived or changed to a different status.
2. The experiment will be in read-only mode after being in archived state.
3. The logs wont get stored for archived experiments, even for the user earlier enrolled in it and had some logs.
4. The logs gets stored in a new Archived table as a backup.
5. While updating state to Archived state, we get a confirmation checkbox, until it's checked, the 'Save' button would be disable.
6. The archived experiments wont be shown on home dashboard experiment list view while the filter is 'All' or any other option except 'Status'. If we select 'Status' option, then we can filter all experiments including 'Archived' using a mat-auto complete search input box.
7. We cannot directly change state from enrolling to archived. Archived state is allowed only after enrolling state is changed to enrollmentComplete state.

[amurphy-cl]

Thanks Pratik, that all sounds exactly right.

[bcb37]

I've gone over this and it all looks good to me.

[ppratikcr7]

I've gone over this and it all looks good to me.

Thanks @bcb37 for the review, you can also approve this and it would't auto merge as I have disabled the option as Dan had also pointed out in slack. We can wait for multiple approvals before merging if needed.

[danoswaltCL]

Just a few small comments from me, there's just the one spot in experiment-list with the filters that feels like it could be refactored to be simpler, but as I looked at it I didn't have any good quick suggestions. Chatgpt also didn't give me any good suggestions.

[VivekFitkariwala]

The frontend doesn't need to know that we are storing the query result of the archive state in a different way. We can use the same endpoint to serve the result.

[RidhamShah]

@VivekFitkariwala Yes, we can merge analysis and achieve branch by giving one more variable to identify which call is sent. I think we made it a different API call because service file functions were very diffenent but now can be manage by if-else.

[VivekFitkariwala]

The changes look good.