remove errorneous error logging and db inserts in group experiment assign call #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivekFitkariwala
previously requested changes
Dec 4, 2024
| const experimentToExcludeIds = experimentToExclude.map((experiment) => experiment.id); | ||
|
|
||
| // throw error user group not defined and add experiments which are excluded | ||
| experimentToExclude.forEach(({ id, name }) => { |
There was a problem hiding this comment.
We should keep the logger and comment out the insertion in the database.
There was a problem hiding this comment.
it's not just the insert that is a problem, when i was testing this yesterday, the log and insert both are called for no reason for most users, regardless of if they have an invalid group or not.
There was a problem hiding this comment.
#2147 (comment) i can demonstrate this in my local in mtg
There was a problem hiding this comment.
will spawn a ticket to revisit this to figure out what the correct warnings we actually value for the scenarios where there really is working-group / group metadata issues.
|
@VivekFitkariwala can i merge this? |
bcb37
previously approved these changes
Dec 5, 2024
danoswaltCL
dismissed
VivekFitkariwala’s stale review
discussed in mtg, spawned a new issue
bcb37
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2147