list endpoint and segment migration #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivekFitkariwala
requested changes
Dec 4, 2024
| if (!segmentDoc) { | ||
| throw new Error(SERVER_ERROR.QUERY_FAILED); | ||
| } | ||
| await Promise.all( |
There was a problem hiding this comment.
These should happen in a transaction
VivekFitkariwala
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value for the /delete segment endpoint (along with the service and repository methods in its call stack) was falsely typed as
Promise<Segment>. It was actually returningPromise<Segment[]>, which the front end was set up to expect. Now the typing is correct (and consistent with the swagger annotation). This pr adjusts the front end code accordingly.