Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExperimentUserController as its not used in the frontend #2087

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Remove ExperimentUserController as its not used in the frontend #2087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92188ff
remove experimentusercontroller as its not used in frontend
ppratikcr7 Oct 30, 2024
703bbd9
Merge branch 'dev' into code-cleanup/remove-experimentusercontroller-…
ppratikcr7 Oct 30, 2024
2f4d59d
removing update function from experimentuserservice as its not used a…
ppratikcr7 Oct 30, 2024
69f4a55
Merge branch 'dev' into code-cleanup/remove-experimentusercontroller-…
ppratikcr7 Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 0 additions & 177 deletions backend/packages/Upgrade/src/api/controllers/ExperimentUserController.ts
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions backend/packages/Upgrade/src/api/services/ExperimentUserService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,6 @@ export class ExperimentUserService {
return this.userRepository.save(newDocument);
}

public update(id: string, user: Partial<ExperimentUser>, logger: UpgradeLogger): Promise<ExperimentUser> {
logger.info({ message: `Update a user ${user.toString()}` });
user.id = id;
return this.userRepository.save(user);
}

// TODO should we check for workingGroup as a subset over here?
public async updateGroupMembership(
userId: string,
Expand Down
90 changes: 0 additions & 90 deletions backend/packages/Upgrade/test/unit/controllers/ExperimentUserController.test.ts
View file
Open in desktop

This file was deleted.

Loading