implemented signals for import-feature-flag #2086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2024 10:58
|
@RidhamShah, I am not sure if I understood this PR. The goal was to move the component-specific state and dataService calls to the component store. There are two requests: validation and import. Both of these calls are not updating the main store as after the import, we are calling |
VivekFitkariwala
requested changes
Nov 5, 2024
frontend/projects/upgrade/src/app/core/feature-flags/store/feature-flag.signal.store.ts
Outdated
Show resolved
Hide resolved
frontend/projects/upgrade/src/app/core/feature-flags/store/feature-flag.signal.store.ts
Outdated
Show resolved
Hide resolved
VivekFitkariwala
requested changes
Nov 26, 2024
frontend/projects/upgrade/src/app/core/feature-flags/feature-flags.module.ts
Outdated
Show resolved
Hide resolved
frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts
Outdated
Show resolved
Hide resolved
...hboard/feature-flags/modals/import-feature-flag-modal/import-feature-flag-modal.component.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used signals with componentStore to call import-feature-flag-api instead of directly calling API and using local store.
Doc - https://ngrx.io/guide/component-store
(Just FYI, componentStore and SignalStore are 2 different things)