(Release) Fix Not-Allowed Cursor Appearing on Enabled Slide Toggles #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcb37
previously approved these changes
Oct 10, 2024
I think the person approving can be the person on the hook to pip the version (if needed), then they can approve and merge without needing a re-approve from someone else in a follow-up PR. I say if needed because it's really only needed the moment before we re-deploy to staging, we don't have to neccessarily worry about pipping every bugfix. I don't want that to hold up merging in code. |
danoswaltCL
approved these changes
Oct 10, 2024
|
(i went ahead and did it, I'll re-deploy) |
shpwe
pushed a commit
that referenced
this pull request
Oct 14, 2024
* intial 6.0.0 version bump * Decoupling join and paginated query * Apply filterMode (includeAll) to an imported Feature Flag (#2031) * (Release) Refine Disabled Slide Toggles and Action Buttons on 'Reader' mode (#2032) * Refine Disabled Slide Toggles and Action Buttons on 'Reader' mode (Release) * Move common mat-mdc-slide-toggle styles to styles.scss * adding exposures to the feature flag paginated query * Bugfix/handy prerelease version bump script (#2033) * add prerelease version bump/removal script * add prerelease bump script and bump to 1 --------- Co-authored-by: Zack Lee <[email protected]> * v6-pre-release version update * (Release) Fix Not-Allowed Cursor Appearing on Enabled Slide Toggles (#2040) * (Release) Fix the Not-Allowed Cursor Bug on Disabled Slide Toggles * version bump --------- Co-authored-by: danoswaltCL <[email protected]> * add var to turn off migrations for ECS (#2041) * add var to turn off migrations for ECS * add var to CF config file * hardcode IS_ECS to 'true' in CF config --------- Co-authored-by: Vivek Fitkariwala <[email protected]> Co-authored-by: Zack Lee <[email protected]> Co-authored-by: pratik <[email protected]> Co-authored-by: Pratik Prajapati <[email protected]> Co-authored-by: Ben Blanchard <[email protected]>
danoswaltCL
added a commit
that referenced
this pull request
Nov 19, 2024
* intial 6.0.0 version bump * Decoupling join and paginated query * Apply filterMode (includeAll) to an imported Feature Flag (#2031) * (Release) Refine Disabled Slide Toggles and Action Buttons on 'Reader' mode (#2032) * Refine Disabled Slide Toggles and Action Buttons on 'Reader' mode (Release) * Move common mat-mdc-slide-toggle styles to styles.scss * adding exposures to the feature flag paginated query * Bugfix/handy prerelease version bump script (#2033) * add prerelease version bump/removal script * add prerelease bump script and bump to 1 --------- Co-authored-by: Zack Lee <[email protected]> * v6-pre-release version update * (Release) Fix Not-Allowed Cursor Appearing on Enabled Slide Toggles (#2040) * (Release) Fix the Not-Allowed Cursor Bug on Disabled Slide Toggles * version bump --------- Co-authored-by: danoswaltCL <[email protected]> * add var to turn off migrations for ECS (#2041) * add var to turn off migrations for ECS * add var to CF config file * hardcode IS_ECS to 'true' in CF config * use branch to build artifacts and deploy automatically to staging (#2056) uses branch as version. * fix config string replacement (#2054) (#2063) * fix config string replacement * set featureFlagNavToggle to true * add quicktests for the clientlibs (#2081) * add quicktests for the clientlibs * commit correct version * fix log response and java CL log call --------- Co-authored-by: Benjamin Blanchard <[email protected]> * Bugfix for experiment data export storing condition name in condition payload column (#2095) * hotfix for condition payload data eport issue and adding types * return NA for no enrolment start and mark date time * removed disable on context change in experiment edit modal (#2094) * removed disable on context change in experiment edit modal * Remove logging checkbox and enableSave variable; Add warning message for Context/Design Type changes in Overview step --------- Co-authored-by: Zack Lee <[email protected]> Co-authored-by: Zack Lee <[email protected]> * Revert Logging Property in the Overview Form (#2103) * fix up package-locks * hotfix to handle duplicate export data csv rows for marking multiple decision points by same user (cherry picked from commit ca84d0a) --------- Co-authored-by: Vivek Fitkariwala <[email protected]> Co-authored-by: Zack Lee <[email protected]> Co-authored-by: pratik <[email protected]> Co-authored-by: Pratik Prajapati <[email protected]> Co-authored-by: Ben Blanchard <[email protected]> Co-authored-by: shpwe <[email protected]> Co-authored-by: Yagnik Hingrajiya <[email protected]> Co-authored-by: Zack Lee <[email protected]>
danoswaltCL
added a commit
that referenced
this pull request
Dec 4, 2024
* intial 6.0.0 version bump * Decoupling join and paginated query * Apply filterMode (includeAll) to an imported Feature Flag (#2031) * (Release) Refine Disabled Slide Toggles and Action Buttons on 'Reader' mode (#2032) * Refine Disabled Slide Toggles and Action Buttons on 'Reader' mode (Release) * Move common mat-mdc-slide-toggle styles to styles.scss * adding exposures to the feature flag paginated query * Bugfix/handy prerelease version bump script (#2033) * add prerelease version bump/removal script * add prerelease bump script and bump to 1 --------- Co-authored-by: Zack Lee <[email protected]> * v6-pre-release version update * (Release) Fix Not-Allowed Cursor Appearing on Enabled Slide Toggles (#2040) * (Release) Fix the Not-Allowed Cursor Bug on Disabled Slide Toggles * version bump --------- Co-authored-by: danoswaltCL <[email protected]> * add var to turn off migrations for ECS (#2041) * add var to turn off migrations for ECS * add var to CF config file * hardcode IS_ECS to 'true' in CF config * use branch to build artifacts and deploy automatically to staging (#2056) uses branch as version. * fix config string replacement (#2054) (#2063) * fix config string replacement * set featureFlagNavToggle to true * add quicktests for the clientlibs (#2081) * add quicktests for the clientlibs * commit correct version * fix log response and java CL log call --------- Co-authored-by: Benjamin Blanchard <[email protected]> * Bugfix for experiment data export storing condition name in condition payload column (#2095) * hotfix for condition payload data eport issue and adding types * return NA for no enrolment start and mark date time * removed disable on context change in experiment edit modal (#2094) * removed disable on context change in experiment edit modal * Remove logging checkbox and enableSave variable; Add warning message for Context/Design Type changes in Overview step --------- Co-authored-by: Zack Lee <[email protected]> Co-authored-by: Zack Lee <[email protected]> * Revert Logging Property in the Overview Form (#2103) * hotfix to handle duplicate export data csv rows for marking multiple decision points by same user (#2117) * update to 6.0.5, ready for prod (#2118) * get export log data from replica (#2125) * update filter mode when ALL row is removed in include table (#2131) * match package version to build tags (#2138) * Update clientlib readme (#2139) * update typedoc generated readme and other docs * fix quick tests * readme typedocs and quicktest brush-ups * update filelockVersion for two packages * fix up package-locks? * remove nounused var from tsconfig for build? --------- Co-authored-by: Vivek Fitkariwala <[email protected]> Co-authored-by: Zack Lee <[email protected]> Co-authored-by: pratik <[email protected]> Co-authored-by: Pratik Prajapati <[email protected]> Co-authored-by: Ben Blanchard <[email protected]> Co-authored-by: shpwe <[email protected]> Co-authored-by: Yagnik Hingrajiya <[email protected]> Co-authored-by: Zack Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the "not-allowed" cursor appearing over the enabled slide toggles for users with the "Admin" role.
Related PR: #2032