Exclusion edge case issue 1404 #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yagnik56
changed the title
VivekFitkariwala
requested changes
Oct 21, 2024
backend/packages/Upgrade/src/api/repositories/ExperimentSegmentExclusionRepository.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/ExperimentAssignmentService.ts
Outdated
Show resolved
Hide resolved
|
|
||
| // Delete Group Enrollment | ||
| if (experimentSegment.experiment.assignmentUnit == ASSIGNMENT_UNIT.GROUP) { | ||
| await this.groupEnrollmentRepository.delete({ |
There was a problem hiding this comment.
Why not creating a promise array and pushing this promise in that array?
VivekFitkariwala
approved these changes
Nov 5, 2024
|
Is this ready? Vivek made comments and then approved, I don't know what that means. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses edge cases related to the inclusion and exclusion of Users and Groups already enrolled in an experiment when either a user or a group is added to the exclusion list based on the Assignment Unit and Consistency Rule.
Cases Covered: