Refine Feature Flags Root Table Pagination on Scroll #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackcl
requested review from
VivekFitkariwala,
bcb37,
ppratikcr7,
Yagnik56 and
danoswaltCL
|
Interesting, makes sense to me. |
danoswaltCL
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #2020 (comment)
This PR removes the use of the
(wheel)directive, which was triggering the fetching of flags and displaying the loading spinner even with slight scrolling. Instead, this PR implements anIntersectionObserverto control when thethis.fetchFlagsOnScroll()function is called.Here's a screen recording demonstrating the changes:
FF.Root.Table.Fetch.on.Scroll.mov