Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include feature flags in segment status #1974

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

bcb37
Copy link
Collaborator

@bcb37 bcb37 commented Sep 20, 2024

  • Adds feature flag public segment use data to the segments page
  • Changes the UI of the 'Used' modal on the segments details page to include feature flag information
Screenshot 2024-09-20 at 5 06 39 PM

@bcb37 bcb37 linked an issue Sep 20, 2024 that may be closed by this pull request
@zackcl
Copy link
Collaborator

zackcl commented Sep 23, 2024

I just have a style suggestion. Updating the column widths of the 'Type', 'Status', and 'Used List' columns to 20% looks better to me.

         .cdk-column-type {
-          flex: 0 0 15%;
+          flex: 0 0 20%;
           justify-content: left;
         }
         .cdk-column-experimentState {
-          flex: 0 0 30%;
+          flex: 0 0 20%;
           justify-content: left;
         }
         .cdk-column-usedList {
-          flex: 0 0 15%;
+          flex: 0 0 20%;
           justify-content: left;
         }

Here's the screenshot after the change:

Screenshot 2024-09-23 at 8 34 05 PM

Also, please apply this change to prevent the circle from being distorted when the status is 'Enrollment Complete':

            &-circle {
               display: inline-block;
               margin-right: 6px;
               border-radius: 50%;
-              width: 12px;
-              height: 12px;
+              min-width: 12px;
+              min-height: 12px;
             }

Before the change:

Screenshot 2024-09-23 at 8 45 14 PM

After the change:
Screenshot 2024-09-23 at 8 42 31 PM

@zackcl zackcl merged commit 0feeeb2 into dev Sep 24, 2024
14 checks passed
@zackcl zackcl deleted the feature/add-feature-flag-use-to-segments branch September 24, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment status not updating for featureFlags
3 participants