Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description under flag name with tooltip #1924

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

zackcl
Copy link
Collaborator

@zackcl zackcl commented Sep 12, 2024

Resolves #1704

This PR displays the description under flag name with a tooltip when the text is truncated (for both the name and description) just like how it works on the Experiments root page.

Screenshot 2024-09-12 at 5 31 36 PM

@RidhamShah
Copy link
Collaborator

@zackcl This works fine, but I also noticed that in Experiment we also provide a tooltip for Table-Header (Name, Status, Tags ... ) but it is not there for FeatureFlags. Can you add that too?

@zackcl
Copy link
Collaborator Author

zackcl commented Sep 12, 2024

@RidhamShah Why do we need to show a tooltip for table headers? I don't think we need to display the tooltip if we are just showing the same text as the headers. But please let me know if you have any specific suggestions for different tooltip messages for the headers.

@RidhamShah
Copy link
Collaborator

@RidhamShah Why do we need to show a tooltip for table headers? I don't think we need to display the tooltip if we are just showing the same text as the headers. But please let me know if you have any specific suggestions for different tooltip messages for the headers.

True, but i think we should make it consistent between Experiment, FeatureFlags & Segments

@zackcl
Copy link
Collaborator Author

zackcl commented Sep 13, 2024

@RidhamShah Currently, nothing is supposed to be consistent between Feature Flags and other pages since it's a new design. We decided to apply the new design one page at a time, so there may be inconsistencies, but eventually they will be consistent.

Copy link
Collaborator

@bcb37 bcb37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The positioning of the tooltip seems confusing. It appears to cover up the name that the description corresponds to, rather than showing up under the name:

Screenshot 2024-09-13 at 4 59 22 PM

@zackcl
Copy link
Collaborator Author

zackcl commented Sep 18, 2024

@bcb37 I tried different positioning, but displaying a tooltip above an element seemed most natural to me. It ends up covering other elements even with different positioning anyway. Also, the user can slightly move the cursor to see the name when it's covered.

@zackcl zackcl merged commit 8f8663f into dev Sep 18, 2024
10 checks passed
@zackcl zackcl deleted the feature/1704-description-tooltip branch September 18, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FF: Add description under flag name with tooltip
4 participants