Display 'No matching feature flags found' message when no flags found from search #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yagnik56 @VivekFitkariwala Please review and approve this PR. |
|
OK, I will first resolve conflicts. |
VivekFitkariwala
requested changes
Sep 11, 2024
...root-page-content/feature-flag-root-section-card/feature-flag-root-section-card.component.ts
Outdated
Show resolved
Hide resolved
...root-page-content/feature-flag-root-section-card/feature-flag-root-section-card.component.ts
Outdated
Show resolved
Hide resolved
...root-page-content/feature-flag-root-section-card/feature-flag-root-section-card.component.ts
Outdated
Show resolved
Hide resolved
|
@VivekFitkariwala I resolved all your comments. Please feel free to approve this PR. |
VivekFitkariwala
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR displays the message "No matching feature flags found" on the Feature Flags Root Section Card Table instead of "No feature flags are defined. Create a new feature flag." when no matching feature flags are found from the search.