feature flag audit logs UI changes #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yagnik56
requested review from
VivekFitkariwala,
danoswaltCL,
ppratikcr7,
RidhamShah and
zackcl
|
|
||
| export { EXPERIMENT_LOG_TYPE, SERVER_ERROR }; | ||
| export { EXPERIMENT_LOG_TYPE, SERVER_ERROR, FEATURE_FLAG_LIST_OPERATION }; |
There was a problem hiding this comment.
This export doesn't make sense directly import from where it si needed.
There was a problem hiding this comment.
@Yagnik56 can you remove the export from here.
frontend/projects/upgrade/src/app/core/logs/logs.service.spec.ts
Outdated
Show resolved
Hide resolved
...d/projects/upgrade/src/app/features/dashboard/logs/components/timeline/timeline.component.ts
Outdated
Show resolved
Hide resolved
VivekFitkariwala
previously approved these changes
Sep 11, 2024
VivekFitkariwala
approved these changes
Sep 11, 2024
Yagnik56
deleted the
enhancement/feature-flags-audit-logs-UI-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes for feature flag audit logs to show them in UI.
BugFix
This also fixes the issue of segment deletion failing in exclusion list.