Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default/fallback filter mode to EXCLUDE_ALL for experiments #1813

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

zackcl
Copy link
Collaborator

@zackcl zackcl commented Aug 8, 2024

This PR updates default/fallback filter mode to EXCLUDE_ALL for experiments.

@zackcl zackcl force-pushed the bugfix/default-exp-filtermode branch from 0e6b990 to a2bc49b Compare August 8, 2024 07:56
Copy link
Collaborator

@Yagnik56 Yagnik56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@danoswaltCL danoswaltCL merged commit 18714d3 into dev Aug 9, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the bugfix/default-exp-filtermode branch August 9, 2024 20:58
@ppratikcr7
Copy link
Collaborator

ppratikcr7 commented Aug 30, 2024

@zackcl Migration file was missing in this PR as model was updated. Yagnik has added this in his latest audit logs PR. Just wanted to inform this, so that we don't miss these changes for future PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants