Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse all section cards in FF details page #1741

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

KD1712
Copy link
Collaborator

@KD1712 KD1712 commented Jul 9, 2024

Added collapsible functionality to toggle all section cards by giving input to 'Inclusion,Exclusion and Exposure' section cards and emitting output from 'overview details'

@KD1712 KD1712 requested review from Yagnik56 and danoswaltCL July 9, 2024 14:19
@KD1712 KD1712 self-assigned this Jul 9, 2024
@KD1712 KD1712 linked an issue Jul 9, 2024 that may be closed by this pull request
@danoswaltCL
Copy link
Collaborator

hold up, we need to add something to the store to handle individual details page ui state so we can handle things like this with redux patterns to avoid making data traverse up and down the component tree in this way. i will get back to you on this, it is end of day...

@danoswaltCL
Copy link
Collaborator

well this is perfectly fine I'll approve, I would rather that we handle kind of thing with the ngrx store / redux patterns but we may need some additional stuff in the reducer to support that better.

@danoswaltCL danoswaltCL merged commit 8016750 into dev Jul 10, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the bugfix/details-overview-collapse-all-1725 branch July 10, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FF Fix: Details Overview section card collapse all
3 participants