Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pagination call on scroll in FF #1712

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Added pagination call on scroll in FF #1712

merged 9 commits into from
Jul 22, 2024

Conversation

KD1712
Copy link
Collaborator

@KD1712 KD1712 commented Jul 2, 2024

I have used 'wheel' event in this PR because 'scroll' event is not working

@KD1712 KD1712 requested review from Yagnik56 and danoswaltCL July 2, 2024 08:48
@KD1712 KD1712 self-assigned this Jul 2, 2024
@KD1712 KD1712 linked an issue Jul 2, 2024 that may be closed by this pull request
FF Root page table: Pagination on scroll #1576
Closed
@danoswaltCL danoswaltCL self-requested a review July 10, 2024 15:31
@KD1712
Copy link
Collaborator Author

KD1712 commented Jul 15, 2024

So now i have removed the subscription for isAllFeaturFlagFetched from the component and updated effect to check isAllFlagsFetched state to prevent unnecessary calls. Ensured proper parameter indexing in the filter logic for accurate state checks and set loader to false when all flags are fetched

@danoswaltCL danoswaltCL self-requested a review July 22, 2024 14:38
@danoswaltCL danoswaltCL merged commit ec71c8d into dev Jul 22, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the feature/FF-pagination-on-scroll branch July 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danoswaltCL danoswaltCL danoswaltCL approved these changes

@Yagnik56 Yagnik56 Awaiting requested review from Yagnik56

Assignees

@KD1712 KD1712

Labels
epic: feature flags
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FF Root page table: Pagination on scroll
2 participants
@KD1712 @danoswaltCL