Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to create feature flag without adding tags #1710

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Not able to create feature flag without adding tags #1710

merged 4 commits into from
Jun 28, 2024

Conversation

Yagnik56
Copy link
Collaborator

This PR fixed the issue of tags sending null instead of array which wasn't allowing to create a feature flag.

@Yagnik56 Yagnik56 requested a review from danoswaltCL June 28, 2024 10:40
@Yagnik56 Yagnik56 self-assigned this Jun 28, 2024
@Yagnik56 Yagnik56 linked an issue Jun 28, 2024 that may be closed by this pull request
Can't create Feature Flag without tags #1708
Closed
@danoswaltCL
Copy link
Collaborator

i see the tags array is being initialized with [] , that looks like why null is coming, should be an empty array [[]].

@danoswaltCL danoswaltCL merged commit 84cc429 into dev Jun 28, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the bugfix/create-feature-flag-fails-without-tags branch June 28, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danoswaltCL danoswaltCL danoswaltCL approved these changes

Assignees

@Yagnik56 Yagnik56

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create Feature Flag without tags
2 participants
@Yagnik56 @danoswaltCL