-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bugfix for missing query metric data columns in csv for first user with no logs #1699
Conversation
…no query logs (cherry picked from commit 67c31f7)
Attaching a sample CSV export which now stores the query metric columns in case the first user has no query logs: |
@amurphy-cl can you verify that the export is as expected |
@amurphy-cl when you get a chance, can you confirm that this improvement to the export is all good? then we can close out this ticket [email protected]_simpleExport2024-06-26T11:53:08.468Z.csv |
This looks great except I'm not sure I understand where the labels from columns V, W, and X come from. Are those defined by the experimenter when setting up metrics? |
Yes, I had kept those names as query names while setting the experiment. Actually these format is already there in dev branch, this PR was created for handling an edge case where these column V, W and X which are the query metrics columns were not present in the export in case the first user in the csv rows was not having any metric logs. This is resolved now in this PR as you can check in this sample exported csv. |
This resolves issue #1690