Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bugfix for missing query metric data columns in csv for first user with no logs #1699

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

ppratikcr7
Copy link
Collaborator

This resolves issue #1690

@ppratikcr7 ppratikcr7 requested review from bcb37 and RidhamShah June 26, 2024 13:30
@ppratikcr7 ppratikcr7 self-assigned this Jun 26, 2024
@ppratikcr7 ppratikcr7 changed the title 🐛 Bugfiix for missing query metric data columns in csv for first user with no logs 🐛 Bugfix for missing query metric data columns in csv for first user with no logs Jun 26, 2024
@ppratikcr7
Copy link
Collaborator Author

Attaching a sample CSV export which now stores the query metric columns in case the first user has no query logs:

[email protected]_simpleExport2024-06-26T11:53:08.468Z.csv

@danoswaltCL
Copy link
Collaborator

@amurphy-cl can you verify that the export is as expected

@ppratikcr7 ppratikcr7 requested a review from amurphy-cl July 8, 2024 08:00
@danoswaltCL
Copy link
Collaborator

@amurphy-cl when you get a chance, can you confirm that this improvement to the export is all good? then we can close out this ticket [email protected]_simpleExport2024-06-26T11:53:08.468Z.csv

@amurphy-cl
Copy link
Collaborator

This looks great except I'm not sure I understand where the labels from columns V, W, and X come from. Are those defined by the experimenter when setting up metrics?

@ppratikcr7
Copy link
Collaborator Author

This looks great except I'm not sure I understand where the labels from columns V, W, and X come from. Are those defined by the experimenter when setting up metrics?

Yes, I had kept those names as query names while setting the experiment. Actually these format is already there in dev branch, this PR was created for handling an edge case where these column V, W and X which are the query metrics columns were not present in the export in case the first user in the csv rows was not having any metric logs. This is resolved now in this PR as you can check in this sample exported csv.

@danoswaltCL danoswaltCL self-requested a review August 2, 2024 19:03
@danoswaltCL danoswaltCL merged commit cd2e80f into dev Aug 2, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the bugfix/missing-metrics-csv-data-issue1690 branch August 2, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export CSV Query Metrics Columns Missing due to absence of first user's query data
3 participants