Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Feature flag modal implemented #1673

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Import Feature flag modal implemented #1673

merged 9 commits into from
Jul 2, 2024

Conversation

KD1712
Copy link
Collaborator

@KD1712 KD1712 commented Jun 20, 2024

No description provided.

@KD1712 KD1712 requested review from Yagnik56 and danoswaltCL June 20, 2024 10:57
@KD1712 KD1712 self-assigned this Jun 20, 2024
@KD1712 KD1712 linked an issue Jun 20, 2024 that may be closed by this pull request
FF Import Modal (large import button layout) #1611
Closed
@danoswaltCL
Copy link
Collaborator

This story can go ahead and add the [showMenuButton]="true" option in the root sections card and wire this up so we can actually launch it with the import button and take a look. A screenshot would be good to add onto the PR as well.

@KD1712
Copy link
Collaborator Author

KD1712 commented Jun 21, 2024

Here's how the modal looks now

Screenshot 2024-06-21 at 11 11 41 AM Screenshot 2024-06-21 at 11 12 06 AM Screenshot 2024-06-21 at 11 20 13 AM

@danoswaltCL
Copy link
Collaborator

i'm gonna hold off on this one for a minute. I think we need to talk about the specifics with @amurphy-cl and the rest of the team, there are some requirements we should walk through as a team, and I'm thinking there's some common elements here with some other planned components: https://www.figma.com/design/GaKw3nDscTnMEOzIf4CAa7/UpGrade-UI-Latest-14-(Final)?node-id=8283-9405&t=Yu13lzUFdS34DkqM-0

@KD1712 KD1712 requested a review from danoswaltCL July 1, 2024 06:11
@danoswaltCL danoswaltCL merged commit 3d642f7 into dev Jul 2, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the feature/FF-import-modal-1611 branch July 2, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danoswaltCL danoswaltCL danoswaltCL approved these changes

@Yagnik56 Yagnik56 Awaiting requested review from Yagnik56

Assignees

@KD1712 KD1712

Labels
epic: feature flags
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FF Import Modal (large import button layout)
2 participants
@KD1712 @danoswaltCL