Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chip and date format in root table #1638

Merged
merged 2 commits into from
Jun 12, 2024
Merged

add chip and date format in root table #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ae6919
add chip and date format in root table
danoswaltCL Jun 10, 2024
7821cff
Merge branch 'dev' into feature/root-table-date-format-and-chip
danoswaltCL Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .../feature-flag-root-section-card-table/feature-flag-root-section-card-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
<th class="ft-12-700" mat-header-cell *matHeaderCellDef mat-sort-header>
<span [matTooltip]="FLAG_TRANSLATION_KEYS.STATUS | translate" matTooltipPosition="above">{{ FLAG_TRANSLATION_KEYS.STATUS | translate | uppercase }}</span>
</th>
<td class="ft-12-600" mat-cell *matCellDef="let flag">{{ flag.status }}</td>
<td class="ft-12-600" mat-cell *matCellDef="let flag">
<app-common-status-indicator-chip [chipClass]="flag.status"></app-common-status-indicator-chip>
</td>
</ng-container>

<ng-container [matColumnDef]="FLAG_ROOT_COLUMN_NAMES.UPDATED_AT">
Expand All @@ -51,7 +53,7 @@
</span>
</th>
<td class="ft-12-600" mat-cell *matCellDef="let flag">
{{ flag.updatedAt }}
{{ flag.updatedAt | date: 'MMM d, y h:mm a' }}
</td>
</ng-container>

Expand Down
5 changes: 4 additions & 1 deletion ...rd/feature-flag-root-section-card-table/feature-flag-root-section-card-table.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ import {
FeatureFlag,
} from '../../../../../../../../core/feature-flags/store/feature-flags.model';
import { MatTableDataSource, MatTableModule } from '@angular/material/table';
import { AsyncPipe, NgIf, NgFor, UpperCasePipe } from '@angular/common';
import { AsyncPipe, NgIf, NgFor, UpperCasePipe, DatePipe } from '@angular/common';
import { MatTooltipModule } from '@angular/material/tooltip';
import { TranslateModule } from '@ngx-translate/core';
import { MatChipsModule } from '@angular/material/chips';
import { RouterModule } from '@angular/router';
import { CommonStatusIndicatorChipComponent } from '../../../../../../../../shared-standalone-component-lib/components';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easy way to get rid of these confusing and brittle relative import paths? I tried a few things with path aliases in ts-config, but couldn't find anything simple that worked.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes there should be, maybe we can spawn a quick task for that.


@Component({
selector: 'app-feature-flag-root-section-card-table',
Expand All @@ -26,6 +27,8 @@ import { RouterModule } from '@angular/router';
UpperCasePipe,
MatChipsModule,
RouterModule,
DatePipe,
CommonStatusIndicatorChipComponent,
],
templateUrl: './feature-flag-root-section-card-table.component.html',
styleUrl: './feature-flag-root-section-card-table.component.scss',
Expand Down
Loading