-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/re throw error in http intercepter #1627
Conversation
return EMPTY; // returning EMPTY instead of throwError as Error is handled using snacker here itself | ||
|
||
// re-throw to allow the error to be caught by the calling code | ||
return throwError(() => new Error(JSON.stringify(err))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just throw error
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, what is the code suggestion to try?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I see just throw err
does work, let me fix the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed @VivekFitkariwala
@VivekFitkariwala is this looking right to you now? I'll need this fixed for the demo. |
@danoswaltCL yup approved |
as discussed in some mtg, we should allow this error keep moving through so the error can be caught in angular components