tabbed footer and details page scaffolding #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yagnik56
approved these changes
May 31, 2024
| <app-common-section-card> | ||
| <div header-left style="background-color: lightskyblue; height: 90px; width: 100%">header-left</div> | ||
| <div header-right style="background-color: lightskyblue; height: 90px; width: 100%">header-right</div> | ||
| <div content style="background-color: lightskyblue; height: 90px; width: 100%">content: Exclusions</div> |
There was a problem hiding this comment.
we shouldn't add inline styles unless ones in CSS are getting overwritten and can't resolve it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
-Adds a common tabbed section card footer
-Implements a basic feature flag details overview card footer
-Scaffolds the details page with empty section cards with pretty gross color for placeholder sections that will annoy us until we fully develop them ✨
-Implements basic tabbed navigation between placeholder section card lists